Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 07ffa3f

Browse filesBrowse files
danbevaddaleax
danbev
authored and
addaleax
committed
build: add check for empty openssl-fips flag
Currently, when specifying the --openssl-fips flag without any path , or an empty path, does not generate an error. If a path is specified then the following error is generated: ERROR: FIPS is not supported in this version of Node.js This commit adds a check so that the error is generated even if the path is empty. PR-URL: #25391 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent fe9b6ee commit 07ffa3f
Copy full SHA for 07ffa3f

File tree

Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1238,7 +1238,7 @@ def without_ssl_error(option):
12381238
if options.openssl_no_asm and options.shared_openssl:
12391239
error('--openssl-no-asm is incompatible with --shared-openssl')
12401240

1241-
if options.openssl_fips:
1241+
if options.openssl_fips or options.openssl_fips == '':
12421242
error('FIPS is not supported in this version of Node.js')
12431243

12441244
configure_library('openssl', o)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.