Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 07fa6c9

Browse filesBrowse files
avivkelleraduh95
authored andcommitted
meta: call create-release-post.yml post release
PR-URL: #60366 Refs: nodejs/nodejs.org#8231 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Claudio Wunder <cwunder@gnome.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 6ab83cf commit 07fa6c9
Copy full SHA for 07fa6c9

File tree

Expand file treeCollapse file tree

3 files changed

+53
-51
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+53
-51
lines changed
Open diff view settings
Collapse file

‎.github/workflows/post-release.yml‎

Copy file name to clipboard
+32Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
name: Post-Release actions
2+
3+
on:
4+
workflow_dispatch:
5+
inputs:
6+
version:
7+
description: The version to generate a blog post for.
8+
type: string
9+
required: true
10+
release:
11+
types: [released]
12+
13+
permissions:
14+
contents: read
15+
16+
jobs:
17+
post-release-actions:
18+
if: github.repository == 'nodejs/node'
19+
runs-on: ubuntu-latest
20+
steps:
21+
- name: Trigger update-links workflow on nodejs/release-cloudflare-worker
22+
run: |
23+
gh workflow run update-links.yml --repo nodejs/release-cloudflare-worker
24+
env:
25+
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
26+
27+
- name: Trigger create-release-post workflow on nodejs/nodejs.org
28+
run: |
29+
gh workflow run create-release-post.yml --repo nodejs/nodejs.org -f version=$VERSION
30+
env:
31+
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
32+
VERSION: ${{ inputs.version || github.event.release.tag_name }}
Collapse file

‎.github/workflows/update-release-links.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/update-release-links.yml
-20Lines changed: 0 additions & 20 deletions
This file was deleted.
Collapse file

‎doc/contributing/releases.md‎

Copy file name to clipboardExpand all lines: doc/contributing/releases.md
+21-31Lines changed: 21 additions & 31 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ official release builds for Node.js, hosted on <https://nodejs.org/>.
3030
* [14. Push the release tag](#14-push-the-release-tag)
3131
* [15. Promote and sign the release builds](#15-promote-and-sign-the-release-builds)
3232
* [16. Check the release](#16-check-the-release)
33-
* [17. Create a blog post](#17-create-a-blog-post)
34-
* [18. Create the release on GitHub](#18-create-the-release-on-github)
33+
* [17. Create the release on GitHub](#17-create-the-release-on-github)
34+
* [18. Create a blog post](#18-create-a-blog-post)
3535
* [19. Announce](#19-announce)
3636
* [20. Celebrate](#20-celebrate)
3737
* [LTS releases](#lts-releases)
@@ -1069,21 +1069,31 @@ have the right internal version strings. Check that the API docs are available
10691069
at <https://nodejs.org/api/>. Check that the release catalog files are correct
10701070
at <https://nodejs.org/dist/index.tab> and <https://nodejs.org/dist/index.json>.
10711071

1072-
### 17. Create a blog post
1072+
### 17. Create the release on GitHub
1073+
1074+
* Go to the [New release page](https://github.com/nodejs/node/releases/new).
1075+
* Select the tag version you pushed earlier.
1076+
* For release title, copy the title from the changelog.
1077+
* For the description, copy the rest of the changelog entry.
1078+
* If you are not releasing the latest "Current", uncheck
1079+
"Set as the latest release".
1080+
* Click on the "Publish release" button.
1081+
1082+
### 18. Create a blog post
10731083

10741084
There is an automatic build that is kicked off when you promote new builds, so
10751085
within a few minutes nodejs.org will be listing your new version as the latest
1076-
release. However, the blog post is not yet fully automatic.
1086+
release, and a blog post draft PR will be created.
10771087

1078-
Create a new blog post by running the [nodejs.org release-post.js script][]:
1088+
In the event that a draft PR _is not created_, the [`scripts:release-post`][] script
1089+
can be used as an alternative:
10791090

10801091
```bash
1081-
node ./apps/site/scripts/release-post/index.mjs x.y.z
1092+
# In the apps/site folder of nodejs/nodejs.org
1093+
node --run scripts:release-post x.y.z
10821094
```
10831095

1084-
This script will use the promoted builds and changelog to generate the post. Run
1085-
`npm run serve` to preview the post locally before pushing to the
1086-
[nodejs.org repository][].
1096+
This script will use the promoted builds and changelog to generate the post.
10871097

10881098
* You can add a short blurb just under the main heading if you want to say
10891099
something important, otherwise the text should be publication ready.
@@ -1098,33 +1108,13 @@ This script will use the promoted builds and changelog to generate the post. Run
10981108
to reflect those changes.
10991109

11001110
* Always use pull-requests on the [nodejs.org repository][]. Be respectful
1101-
of the website team, but you do not have to wait for PR sign-off. Please
1102-
use the following commit message format:
1103-
1104-
```console
1105-
Blog: vX.Y.Z release post
1106-
1107-
Refs: <full URL to your release proposal PR>
1108-
```
1109-
1110-
* In order to trigger the CI Checks of the [nodejs.org repository][]; Please
1111-
attach the `github_actions:pull-request` label to the PR.
1111+
of the website team, but you do not have to wait for PR sign-off.
11121112

11131113
* Changes to the base branch, `main`, on the [nodejs.org repository][] will
11141114
trigger a new build of nodejs.org, so your changes should appear a few minutes
11151115
after pushing. You can follow the [Deployments](https://github.com/nodejs/nodejs.org/deployments) page
11161116
to see when the build finishes and gets published.
11171117

1118-
### 18. Create the release on GitHub
1119-
1120-
* Go to the [New release page](https://github.com/nodejs/node/releases/new).
1121-
* Select the tag version you pushed earlier.
1122-
* For release title, copy the title from the changelog.
1123-
* For the description, copy the rest of the changelog entry.
1124-
* If you are not releasing the latest "Current", uncheck
1125-
"Set as the latest release".
1126-
* Click on the "Publish release" button.
1127-
11281118
### 19. Announce
11291119

11301120
The nodejs.org website will automatically rebuild and include the new version.
@@ -1491,7 +1481,7 @@ Typical resolution: sign the release again.
14911481
[Node.js Snap management repository]: https://github.com/nodejs/snap
14921482
[Snap]: https://snapcraft.io/node
14931483
[`create-release-proposal`]: https://github.com/nodejs/node/actions/workflows/create-release-proposal.yml
1484+
[`scripts:release-post`]: https://github.com/nodejs/nodejs.org/blob/HEAD/apps/site/scripts/release-post/index.mjs
14941485
[build-infra team]: https://github.com/orgs/nodejs/teams/build-infra
14951486
[expected assets]: https://github.com/nodejs/build/tree/HEAD/ansible/www-standalone/tools/promote/expected_assets
1496-
[nodejs.org release-post.js script]: https://github.com/nodejs/nodejs.org/blob/HEAD/apps/site/scripts/release-post/index.mjs
14971487
[nodejs.org repository]: https://github.com/nodejs/nodejs.org

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.