Commit 07b6bf4
stream: resume stream on drain
Previously we would just resume "flowing" the stream without
reseting the "paused" state. Fixes this by properly using
pause/resume methods for .pipe.
Fixes: #41785
PR-URL: #41848
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 5085813 commit 07b6bf4Copy full SHA for 07b6bf4
File tree
Expand file treeCollapse file tree
2 files changed
+17
-2
lines changedOpen diff view settings
Filter options
- lib/internal/streams
- test/parallel
Expand file treeCollapse file tree
2 files changed
+17
-2
lines changedOpen diff view settings
Collapse file
lib/internal/streams/readable.js
Copy file name to clipboardExpand all lines: lib/internal/streams/readable.js+1-2Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
853 | 853 | |
854 | 854 | |
855 | 855 | |
856 | | - |
857 | | - |
| 856 | + |
858 | 857 | |
859 | 858 | |
860 | 859 | |
|
Collapse file
test/parallel/test-stream-readable-pause-and-resume.js
Copy file name to clipboardExpand all lines: test/parallel/test-stream-readable-pause-and-resume.js+16Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
56 | 56 | |
57 | 57 | |
58 | 58 | |
| 59 | + |
| 60 | + |
| 61 | + |
| 62 | + |
| 63 | + |
| 64 | + |
| 65 | + |
| 66 | + |
| 67 | + |
| 68 | + |
| 69 | + |
| 70 | + |
| 71 | + |
| 72 | + |
| 73 | + |
| 74 | + |
0 commit comments