Commit 06752d1
net: remove misleading comment
The allowHalfOpen comment was added in commit 8a3befa ("net: Refactor
to use streams2") from 2012 but it wasn't true even then as far as I
can tell: Node.js simply always does a shutdown(2) first.
It is true that streams2 withholds the 'end' event when allowHalfOpen
is true but the comment is about a callback that hangs off the 'finish'
event that is emitted after calling `socket.end()`.
PR-URL: #11573
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent c0663e5 commit 06752d1Copy full SHA for 06752d1
File tree
Expand file treeCollapse file tree
1 file changed
+0
-4
lines changedOpen diff view settings
Filter options
- lib
Expand file treeCollapse file tree
1 file changed
+0
-4
lines changedOpen diff view settings
Collapse file
-4Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
205 | 205 | |
206 | 206 | |
207 | 207 | |
208 | | - |
209 | | - |
210 | | - |
211 | | - |
212 | 208 | |
213 | 209 | |
214 | 210 | |
|
0 commit comments