Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 066d814

Browse filesBrowse files
TrottBridgeAR
authored andcommitted
test: remove unused output argument for getFrames()
PR-URL: #28183 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 5d8dce4 commit 066d814
Copy full SHA for 066d814

File tree

Expand file treeCollapse file tree

3 files changed

+5
-6
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+5
-6
lines changed
Open diff view settings
Collapse file

‎test/common/README.md‎

Copy file name to clipboardExpand all lines: test/common/README.md
+1-2Lines changed: 1 addition & 2 deletions
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -450,9 +450,8 @@ Windows and `30` elsewhere.
450450

451451
Returns an array of all `.cpuprofile` files found in `dir`.
452452

453-
### getFrames(output, file, suffix)
453+
### getFrames(file, suffix)
454454

455-
* `output` Unused.
456455
* `file` {string} Path to a `.cpuprofile` file.
457456
* `suffix` {string} Suffix of the URL of call frames to retrieve.
458457
* returns { frames: [&lt;Object>], nodes: [&lt;Object>] }
Collapse file

‎test/common/cpu-prof.js‎

Copy file name to clipboardExpand all lines: test/common/cpu-prof.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ function getCpuProfiles(dir) {
1414
.map((file) => path.join(dir, file));
1515
}
1616

17-
function getFrames(output, file, suffix) {
17+
function getFrames(file, suffix) {
1818
const data = fs.readFileSync(file, 'utf8');
1919
const profile = JSON.parse(data);
2020
const frames = profile.nodes.filter((i) => {
@@ -25,7 +25,7 @@ function getFrames(output, file, suffix) {
2525
}
2626

2727
function verifyFrames(output, file, suffix) {
28-
const { frames, nodes } = getFrames(output, file, suffix);
28+
const { frames, nodes } = getFrames(file, suffix);
2929
if (frames.length === 0) {
3030
// Show native debug output and the profile for debugging.
3131
console.log(output.stderr.toString());
Collapse file

‎test/parallel/test-cpu-prof-dir-worker.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cpu-prof-dir-worker.js
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ const {
4141
assert(fs.existsSync(dir));
4242
const profiles = getCpuProfiles(dir);
4343
assert.strictEqual(profiles.length, 2);
44-
const profile1 = getFrames(output, profiles[0], 'fibonacci.js');
45-
const profile2 = getFrames(output, profiles[1], 'fibonacci.js');
44+
const profile1 = getFrames(profiles[0], 'fibonacci.js');
45+
const profile2 = getFrames(profiles[1], 'fibonacci.js');
4646
if (profile1.frames.length === 0 && profile2.frames.length === 0) {
4747
// Show native debug output and the profile for debugging.
4848
console.log(output.stderr.toString());

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.