Commit 05fd160
test: use Promise.all() in test-hash-seed
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.
PR-URL: #32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>1 parent 1476182 commit 05fd160Copy full SHA for 05fd160
File tree
Expand file treeCollapse file tree
1 file changed
+16
-21
lines changedOpen diff view settings
Filter options
- test/pummel
Expand file treeCollapse file tree
1 file changed
+16
-21
lines changedOpen diff view settings
Collapse file
test/pummel/test-hash-seed.js
Copy file name to clipboard+16-21Lines changed: 16 additions & 21 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1 | 1 | |
2 | 2 | |
3 | 3 | |
4 | | - |
5 | | - |
6 | | - |
| 4 | + |
| 5 | + |
7 | 6 | |
8 | 7 | |
9 | | - |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
10 | 13 | |
11 | | - |
12 | 14 | |
13 | | - |
14 | | - |
| 15 | + |
| 16 | + |
| 17 | + |
15 | 18 | |
16 | | - |
17 | | - |
18 | | - |
19 | | - |
| 19 | + |
| 20 | + |
20 | 21 | |
21 | | - |
22 | | - |
23 | | - |
24 | | - |
25 | | - |
| 22 | + |
| 23 | + |
26 | 24 | |
27 | | - |
28 | | - |
29 | | - |
30 | | - |
31 | | - |
| 25 | + |
| 26 | + |
0 commit comments