Commit 05ad792
async_hooks: remove experimental onPropagate option
The `onPropagate` option for `AsyncLocalStorage` is problematic for a
couple of reasons:
1. It is not expected to be forwards compatible in any way with the
upcoming TC-39 `AsyncContext` proposal.
2. It introduces a non-trivial O(n) cost invoking a JavaScript callback
for *every* AsyncResource that is created, including every Promise.
While it is still experimental, I recommend removing it while we can
revisit the fundamental use cases in light of the coming `AsyncContext`
proposal.
Refs: #46374
PR-URL: #46386
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent 33a98c4 commit 05ad792Copy full SHA for 05ad792
File tree
Expand file treeCollapse file tree
3 files changed
+9
-80
lines changedOpen diff view settings
Filter options
- doc/api
- lib
- test/async-hooks
Expand file treeCollapse file tree
3 files changed
+9
-80
lines changedOpen diff view settings
Collapse file
+7-17Lines changed: 7 additions & 17 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
116 | 116 | |
117 | 117 | |
118 | 118 | |
119 | | - |
| 119 | + |
120 | 120 | |
121 | 121 | |
122 | 122 | |
123 | 123 | |
124 | 124 | |
125 | 125 | |
126 | | - |
| 126 | + |
| 127 | + |
| 128 | + |
| 129 | + |
| 130 | + |
| 131 | + |
127 | 132 | |
128 | 133 | |
129 | 134 | |
130 | 135 | |
131 | | - |
132 | | - |
133 | | - |
134 | | - |
135 | | - |
136 | | - |
137 | | - |
138 | 136 | |
139 | 137 | |
140 | 138 | |
141 | | - |
142 | | - |
143 | | - |
144 | | - |
145 | | - |
146 | | - |
147 | | - |
148 | 139 | |
149 | 140 | |
150 | 141 | |
| ||
834 | 825 | |
835 | 826 | |
836 | 827 | |
837 | | - |
838 | 828 | |
Collapse file
+2-13Lines changed: 2 additions & 13 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
23 | 23 | |
24 | 24 | |
25 | 25 | |
26 | | - |
27 | 26 | |
28 | 27 | |
29 | 28 | |
| ||
275 | 274 | |
276 | 275 | |
277 | 276 | |
278 | | - |
279 | | - |
280 | | - |
281 | | - |
282 | | - |
283 | | - |
284 | | - |
285 | | - |
| 277 | + |
286 | 278 | |
287 | 279 | |
288 | | - |
289 | 280 | |
290 | 281 | |
291 | 282 | |
| ||
312 | 303 | |
313 | 304 | |
314 | 305 | |
315 | | - |
316 | | - |
317 | | - |
| 306 | + |
318 | 307 | |
319 | 308 | |
320 | 309 | |
|
Collapse file
test/async-hooks/test-async-local-storage-stop-propagation.js
Copy file name to clipboardExpand all lines: test/async-hooks/test-async-local-storage-stop-propagation.js-50Lines changed: 0 additions & 50 deletions
This file was deleted.
0 commit comments