Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 039cd00

Browse filesBrowse files
shisamaBridgeAR
authored andcommitted
dns: add dns/promises alias
PR-URL: #32953 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 7a094dc commit 039cd00
Copy full SHA for 039cd00

File tree

Expand file treeCollapse file tree

6 files changed

+60
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

6 files changed

+60
-1
lines changed
Open diff view settings
Collapse file

‎doc/api/dns.md‎

Copy file name to clipboardExpand all lines: doc/api/dns.md
+1-1Lines changed: 1 addition & 1 deletion
  • Display the source diff
  • Display the rich diff
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ earlier ones time out or result in some other error.
611611

612612
The `dns.promises` API provides an alternative set of asynchronous DNS methods
613613
that return `Promise` objects rather than using callbacks. The API is accessible
614-
via `require('dns').promises`.
614+
via `require('dns').promises` or `require('dns/promises')`.
615615

616616
### Class: `dnsPromises.Resolver`
617617
<!-- YAML
Collapse file

‎lib/dns/promises.js‎

Copy file name to clipboard
+5Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
const dnsPromises = require('internal/dns/promises');
4+
dnsPromises.setServers = require('dns').setServers;
5+
module.exports = dnsPromises;
Collapse file

‎node.gyp‎

Copy file name to clipboardExpand all lines: node.gyp
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@
4848
'lib/cluster.js',
4949
'lib/dgram.js',
5050
'lib/dns.js',
51+
'lib/dns/promises.js',
5152
'lib/domain.js',
5253
'lib/events.js',
5354
'lib/fs.js',
Collapse file
+14Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
// Flags: --expose-internals
2+
import '../common/index.mjs';
3+
import assert from 'assert';
4+
import { lookupService } from 'dns/promises';
5+
6+
const invalidAddress = 'fasdfdsaf';
7+
8+
assert.throws(() => {
9+
lookupService(invalidAddress, 0);
10+
}, {
11+
code: 'ERR_INVALID_OPT_VALUE',
12+
name: 'TypeError',
13+
message: `The value "${invalidAddress}" is invalid for option "address"`
14+
});
Collapse file
+6Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
'use strict';
2+
3+
require('../common');
4+
const assert = require('assert');
5+
6+
assert.strictEqual(require('dns/promises'), require('dns').promises);
Collapse file

‎test/parallel/test-dns-setservers-type-check.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-dns-setservers-type-check.js
+33Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,3 +85,36 @@ const promiseResolver = new dns.promises.Resolver();
8585
);
8686
});
8787
}
88+
89+
// This test for 'dns/promises'
90+
{
91+
const {
92+
setServers
93+
} = require('dns/promises');
94+
95+
// This should not throw any error.
96+
(async () => {
97+
setServers([ '127.0.0.1' ]);
98+
})();
99+
100+
[
101+
[null],
102+
[undefined],
103+
[Number(addresses.DNS4_SERVER)],
104+
[
105+
{
106+
address: addresses.DNS4_SERVER
107+
}
108+
]
109+
].forEach((val) => {
110+
const errObj = {
111+
code: 'ERR_INVALID_ARG_TYPE',
112+
name: 'TypeError',
113+
message: 'The "servers[0]" argument must be of type string.' +
114+
common.invalidArgTypeHelper(val[0])
115+
};
116+
assert.throws(() => {
117+
setServers(val);
118+
}, errObj);
119+
});
120+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.