Commit 032c23d
build: make linter failures fail
Linter failures in the `test-doc` make target were not failing the
build if the subsequent `doctools` test passed as its exit code
wasn't being preserved.
Make the `lint` target a dependency of `test-doc` so that it is
outside of the `node_use_openssl` guard -- its own dependencies
have their own guards where necessary and the targets that don't
require an available node (e.g. the C++ linters) will be allowed
to run.
PR-URL: #30012
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>test-doc target1 parent abfac96 commit 032c23dCopy full SHA for 032c23d
File tree
Expand file treeCollapse file tree
1 file changed
+1
-2
lines changedOpen diff view settings
Filter options
Expand file treeCollapse file tree
1 file changed
+1
-2
lines changedOpen diff view settings
Collapse file
+1-2Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
592 | 592 | |
593 | 593 | |
594 | 594 | |
595 | | - |
| 595 | + |
596 | 596 | |
597 | 597 | |
598 | 598 | |
599 | | - |
600 | 599 | |
601 | 600 | |
602 | 601 | |
|
0 commit comments