Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 02e012e

Browse filesBrowse files
TrottFishrock123
authored andcommitted
src: force line buffering for stderr
SmartOS does not line buffer stderr by default, or at least that is the behavior on the Node project Jenkins server. Force line buffering. This resolves the flakiness observed on SmartOS for test-debug-signal-cluster. PR-URL: #3701 Fixes: #2476 Refs: #3615 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
1 parent 597f875 commit 02e012e
Copy full SHA for 02e012e

File tree

Expand file treeCollapse file tree

2 files changed

+1
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+1
-1
lines changed
Open diff view settings
Collapse file

‎src/node_main.cc‎

Copy file name to clipboardExpand all lines: src/node_main.cc
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ int wmain(int argc, wchar_t *wargv[]) {
4141
#else
4242
// UNIX
4343
int main(int argc, char *argv[]) {
44+
setvbuf(stderr, NULL, _IOLBF, 1024);
4445
return node::Start(argc, argv);
4546
}
4647
#endif
Collapse file

‎test/parallel/parallel.status‎

Copy file name to clipboardExpand all lines: test/parallel/parallel.status
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ test-child-process-exit-code : PASS,FLAKY
1818
[$system==macos]
1919

2020
[$system==solaris] # Also applies to SmartOS
21-
test-debug-signal-cluster : PASS,FLAKY
2221

2322
[$system==freebsd]
2423
test-net-socket-local-address : PASS,FLAKY

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.