Commit 02d7283
deps: V8: cherry-pick 0dfd9ea51241
Original commit message:
[coverage] Fix coverage with default arguments
In the presence of default arguments, the body of the function gets
wrapped into another block. This caused our trailing-range-after-return
optimization to not apply, because the wrapper block had no source
range assigned. This CL correctly assignes a source range to that block,
which allows already present code to handle it correctly.
Note that this is not a real coverage bug; we've just been reporting
whitespace as uncovered. We're fixing it for consistency.
Originally reported on github.com/bcoe/c8/issues/66
Bug: v8:9952
Change-Id: Iab3905f558eb99126e0dad8072d03d0a312fdcd3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903430
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64836}
Refs: v8/v8@0dfd9ea
Backport-PR-URL: #31412
PR-URL: #30713
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent ad4af04 commit 02d7283Copy full SHA for 02d7283
File tree
Expand file treeCollapse file tree
3 files changed
+39
-1
lines changedOpen diff view settings
Filter options
- deps/v8
- src/parsing
- test/mjsunit
Expand file treeCollapse file tree
3 files changed
+39
-1
lines changedOpen diff view settings
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
38 | 38 | |
39 | 39 | |
40 | 40 | |
41 | | - |
| 41 | + |
42 | 42 | |
43 | 43 | |
44 | 44 | |
|
Collapse file
deps/v8/src/parsing/parser-base.h
Copy file name to clipboardExpand all lines: deps/v8/src/parsing/parser-base.h+1Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
4087 | 4087 | |
4088 | 4088 | |
4089 | 4089 | |
| 4090 | + |
4090 | 4091 | |
4091 | 4092 | |
4092 | 4093 | |
|
Collapse file
deps/v8/test/mjsunit/code-coverage-block.js
Copy file name to clipboardExpand all lines: deps/v8/test/mjsunit/code-coverage-block.js+37Lines changed: 37 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
1097 | 1097 | |
1098 | 1098 | |
1099 | 1099 | |
| 1100 | + |
| 1101 | + |
| 1102 | + |
| 1103 | + |
| 1104 | + |
| 1105 | + |
| 1106 | + |
| 1107 | + |
| 1108 | + |
| 1109 | + |
| 1110 | + |
| 1111 | + |
| 1112 | + |
| 1113 | + |
| 1114 | + |
| 1115 | + |
| 1116 | + |
| 1117 | + |
| 1118 | + |
| 1119 | + |
| 1120 | + |
| 1121 | + |
| 1122 | + |
| 1123 | + |
| 1124 | + |
| 1125 | + |
| 1126 | + |
| 1127 | + |
| 1128 | + |
| 1129 | + |
| 1130 | + |
| 1131 | + |
| 1132 | + |
| 1133 | + |
| 1134 | + |
| 1135 | + |
| 1136 | + |
1100 | 1137 | |
0 commit comments