Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 02b54af

Browse filesBrowse files
refackMylesBorins
authored andcommitted
deps: V8: add workaround for MSVC optimizer bug
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html Backport-PR-URL: #30109 PR-URL: #28016 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 367620c commit 02b54af
Copy full SHA for 02b54af

File tree

Expand file treeCollapse file tree

2 files changed

+10
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+10
-1
lines changed
Open diff view settings
Collapse file

‎common.gypi‎

Copy file name to clipboardExpand all lines: common.gypi
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.6',
41+
'v8_embedder_string': '-node.7',
4242

4343
##### V8 defaults for Node.js #####
4444

Collapse file

‎deps/v8/src/builtins/setup-builtins-internal.cc‎

Copy file name to clipboardExpand all lines: deps/v8/src/builtins/setup-builtins-internal.cc
+9Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -276,6 +276,10 @@ Code GenerateBytecodeHandler(Isolate* isolate, int builtin_index,
276276

277277
} // namespace
278278

279+
#ifdef _MSC_VER
280+
#pragma optimize( "", off )
281+
#endif
282+
279283
// static
280284
void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
281285
Builtins* builtins = isolate->builtins();
@@ -353,5 +357,10 @@ void SetupIsolateDelegate::SetupBuiltinsInternal(Isolate* isolate) {
353357
builtins->MarkInitialized();
354358
}
355359

360+
#ifdef _MSC_VER
361+
#pragma optimize( "", on )
362+
#endif
363+
364+
356365
} // namespace internal
357366
} // namespace v8

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.