Commit 02afdbc
vm: flip Module#link's signature
The specifier parameter is deemed to be more essential than
referencingModule. Flipping the parameter order allows developers to
write simple linker functions that only take in a specifier.
PR-URL: #18471
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent de3231c commit 02afdbcCopy full SHA for 02afdbc
File tree
Expand file treeCollapse file tree
4 files changed
+9
-10
lines changedOpen diff view settings
Filter options
- doc/api
- lib/internal/vm
- test/parallel
Expand file treeCollapse file tree
4 files changed
+9
-10
lines changedOpen diff view settings
Collapse file
+2-3Lines changed: 2 additions & 3 deletions
- Display the source diff
- Display the rich diff
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
117 | 117 | |
118 | 118 | |
119 | 119 | |
120 | | - |
| 120 | + |
121 | 121 | |
122 | 122 | |
123 | 123 | |
| ||
319 | 319 | |
320 | 320 | |
321 | 321 | |
322 | | - |
323 | 322 | |
324 | | - |
325 | 323 | |
326 | 324 | |
327 | 325 | |
328 | 326 | |
329 | 327 | |
| 328 | + |
330 | 329 | |
331 | 330 | |
332 | 331 | |
|
Collapse file
+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
135 | 135 | |
136 | 136 | |
137 | 137 | |
138 | | - |
| 138 | + |
139 | 139 | |
140 | 140 | |
141 | 141 | |
|
Collapse file
test/parallel/test-vm-module-errors.js
Copy file name to clipboardExpand all lines: test/parallel/test-vm-module-errors.js+1-1Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
109 | 109 | |
110 | 110 | |
111 | 111 | |
112 | | - |
| 112 | + |
113 | 113 | |
114 | 114 | |
115 | 115 | |
|
Collapse file
test/parallel/test-vm-module-link.js
Copy file name to clipboardExpand all lines: test/parallel/test-vm-module-link.js+5-5Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
18 | 18 | |
19 | 19 | |
20 | 20 | |
21 | | - |
| 21 | + |
22 | 22 | |
23 | 23 | |
24 | 24 | |
| ||
38 | 38 | |
39 | 39 | |
40 | 40 | |
41 | | - |
| 41 | + |
42 | 42 | |
43 | 43 | |
44 | 44 | |
| ||
68 | 68 | |
69 | 69 | |
70 | 70 | |
71 | | - |
| 71 | + |
72 | 72 | |
73 | 73 | |
74 | | - |
| 74 | + |
75 | 75 | |
76 | 76 | |
77 | 77 | |
| ||
111 | 111 | |
112 | 112 | |
113 | 113 | |
114 | | - |
| 114 | + |
115 | 115 | |
116 | 116 | |
117 | 117 | |
|
0 commit comments