Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 018159d

Browse filesBrowse files
refacktargos
authored andcommitted
tools,gyp: introduce MSVS 2019
Backport-PR-URL: #28005 PR-URL: #27375 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent 5101e4c commit 018159d
Copy full SHA for 018159d

File tree

Expand file treeCollapse file tree

1 file changed

+13
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+13
-1
lines changed
Open diff view settings
Collapse file

‎tools/gyp/pylib/gyp/MSVSVersion.py‎

Copy file name to clipboardExpand all lines: tools/gyp/pylib/gyp/MSVSVersion.py
+13-1Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,6 +257,16 @@ def _CreateVersion(name, path, sdk_based=False):
257257
if path:
258258
path = os.path.normpath(path)
259259
versions = {
260+
'2019': VisualStudioVersion('2019',
261+
'Visual Studio 2019',
262+
solution_version='12.00',
263+
project_version='16.0',
264+
flat_sln=False,
265+
uses_vcxproj=True,
266+
path=path,
267+
sdk_based=sdk_based,
268+
default_toolset='v142',
269+
compatible_sdks=['v8.1', 'v10.0']),
260270
'2017': VisualStudioVersion('2017',
261271
'Visual Studio 2017',
262272
solution_version='12.00',
@@ -387,6 +397,7 @@ def _DetectVisualStudioVersions(versions_to_check, force_express):
387397
2013(e) - Visual Studio 2013 (12)
388398
2015 - Visual Studio 2015 (14)
389399
2017 - Visual Studio 2017 (15)
400+
2019 - Visual Studio 2019 (16)
390401
Where (e) is e for express editions of MSVS and blank otherwise.
391402
"""
392403
version_to_year = {
@@ -396,7 +407,8 @@ def _DetectVisualStudioVersions(versions_to_check, force_express):
396407
'11.0': '2012',
397408
'12.0': '2013',
398409
'14.0': '2015',
399-
'15.0': '2017'
410+
'15.0': '2017',
411+
'16.0': '2019',
400412
}
401413
versions = []
402414
for version in versions_to_check:

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.