Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 01746c7

Browse filesBrowse files
lpincaruyadorno
authored andcommitted
http: null the joinDuplicateHeaders property on cleanup
Null the `joinDuplicateHeaders` property when the parser is freed. Refs: #45982 PR-URL: #48608 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
1 parent 6ec5798 commit 01746c7
Copy full SHA for 01746c7

File tree

Expand file treeCollapse file tree

2 files changed

+8
-1
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

2 files changed

+8
-1
lines changed
Open diff view settings
Collapse file

‎lib/_http_common.js‎

Copy file name to clipboardExpand all lines: lib/_http_common.js
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ function cleanParser(parser) {
236236
parser[kOnTimeout] = null;
237237
parser._consumed = false;
238238
parser.onIncoming = null;
239+
parser.joinDuplicateHeaders = null;
239240
}
240241

241242
function prepareError(err, parser, rawPacket) {
Collapse file

‎test/parallel/test-http-parser-memory-retention.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-parser-memory-retention.js
+7-1Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,24 @@ server.on('request', common.mustCall((request, response) => {
2525
}));
2626

2727
server.listen(common.mustCall(() => {
28-
const request = http.get({ port: server.address().port });
28+
const request = http.get({
29+
headers: { Connection: 'close' },
30+
port: server.address().port,
31+
joinDuplicateHeaders: true
32+
});
2933
let parser;
3034

3135
request.on('socket', common.mustCall(() => {
3236
parser = request.parser;
3337
assert.strictEqual(typeof parser.onIncoming, 'function');
38+
assert.strictEqual(parser.joinDuplicateHeaders, true);
3439
}));
3540

3641
request.on('response', common.mustCall((response) => {
3742
response.resume();
3843
response.on('end', common.mustCall(() => {
3944
assert.strictEqual(parser.onIncoming, null);
45+
assert.strictEqual(parser.joinDuplicateHeaders, null);
4046
}));
4147
}));
4248
}));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.