Commit 0165a76
bootstrap: do not expand process.argv[1] for snapshot entry points
In applications with entry points deserialized from snapshots,
they don't need an additional CLI argument for the entry point script
so process.argv[1] is going to be other user-defiend arguments.
We could consider copying process.argv[0] as process.argv[1] like
what we do for single executable applications, but for now just
don't exapnd it so it's easier to backport to previous releases.
PR-URL: #47466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent a0b9853 commit 0165a76Copy full SHA for 0165a76
File tree
Expand file treeCollapse file tree
2 files changed
+60
-1
lines changedOpen diff view settings
Filter options
- lib/internal/v8
- test/parallel
Expand file treeCollapse file tree
2 files changed
+60
-1
lines changedOpen diff view settings
Collapse file
lib/internal/v8/startup_snapshot.js
Copy file name to clipboardExpand all lines: lib/internal/v8/startup_snapshot.js+2-1Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
90 | 90 | |
91 | 91 | |
92 | 92 | |
93 | | - |
| 93 | + |
| 94 | + |
94 | 95 | |
95 | 96 | |
96 | 97 | |
|
Collapse file
test/parallel/test-snapshot-argv1.js
Copy file name to clipboard+58Lines changed: 58 additions & 0 deletions
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| ||
| 1 | + |
| 2 | + |
| 3 | + |
| 4 | + |
| 5 | + |
| 6 | + |
| 7 | + |
| 8 | + |
| 9 | + |
| 10 | + |
| 11 | + |
| 12 | + |
| 13 | + |
| 14 | + |
| 15 | + |
| 16 | + |
| 17 | + |
| 18 | + |
| 19 | + |
| 20 | + |
| 21 | + |
| 22 | + |
| 23 | + |
| 24 | + |
| 25 | + |
| 26 | + |
| 27 | + |
| 28 | + |
| 29 | + |
| 30 | + |
| 31 | + |
| 32 | + |
| 33 | + |
| 34 | + |
| 35 | + |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | + |
| 40 | + |
| 41 | + |
| 42 | + |
| 43 | + |
| 44 | + |
| 45 | + |
| 46 | + |
| 47 | + |
| 48 | + |
| 49 | + |
| 50 | + |
| 51 | + |
| 52 | + |
| 53 | + |
| 54 | + |
| 55 | + |
| 56 | + |
| 57 | + |
| 58 | + |
0 commit comments