Refactor labels to use Regex-keyed Maps#41
Merged
phillipj merged 2 commits intonodejs:masternodejs/github-bot:masterfrom May 12, 2016
Merged
Refactor labels to use Regex-keyed Maps#41phillipj merged 2 commits intonodejs:masternodejs/github-bot:masterfrom
phillipj merged 2 commits intonodejs:masternodejs/github-bot:masterfrom
Conversation
Allows for more extensibility where labels may be the same.
Contributor
Author
|
v4 and v5 obviously fail with this |
Member
|
Nice refactoring 👍 While you're at it, could you remove v4 and v5 from |
(Due to destructuring)
Contributor
Author
|
@phillipj done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for more extensibility where labels may be the same. (e.g. more than one
$1mapping)Requires Node.js v6.0.0+ for the destructing in the
for ofloop.cc @phillipj