Fix regexp for anonymous functions#30
Closed
laomaiweng wants to merge 1 commit intonodegit:masternodegit/promisify-node:masterfrom
Closed
Fix regexp for anonymous functions#30laomaiweng wants to merge 1 commit intonodegit:masternodegit/promisify-node:masterfrom
laomaiweng wants to merge 1 commit intonodegit:masternodegit/promisify-node:masterfrom
Conversation
The arguments-matching regexp in _utils/arg.js_ fails for anonymous functions (`function (args) { ... }`) because it expects a space after `function`. Add a non-capturing group to make the space and function name optional.
Member
|
Hi @laomaiweng thanks for the PR, I ended up going a different route with the regex to also support arrow functions. I tried your approach with my new unit test and was not able to get it to pass. I'm going to close this pr in favor of #31. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arguments-matching regexp in utils/arg.js fails for anonymous functions (
function(args) { ... }) because it expects a space afterfunction.Add a non-capturing group to make the space and function name optional.
This was spotted while trying to build nodegit from source.