updated arg regex#19
Closed
awolden wants to merge 1 commit intonodegit:masternodegit/promisify-node:masterfrom
Closed
updated arg regex#19awolden wants to merge 1 commit intonodegit:masternodegit/promisify-node:masterfrom
awolden wants to merge 1 commit intonodegit:masternodegit/promisify-node:masterfrom
Conversation
|
I think support for arrow functions also needs a change in index.js line 88 if (exports.prototype && Object.keys(exports.prototype).length) {since I've been getting exports.prototype as |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for issue: #18
I have updated the regex to support the following additional function definitions:
test(cb){cb();} //example: class Test { constructor(){} test(cb){cb();} }
(cb)=>{cb()}
I was going to add test cases to prove that it accepts the new function declarations, but I didn't want to break your build in older versions of node since you have .10 and .12 in your
.travis.yml