Fix issue with async functions being cached as-is, and so not getting…#14
Merged
maxkorp merged 1 commit intonodegit:masternodegit/promisify-node:masterfrom Nov 30, 2015
jon-hall:feature/unwrapped-function-cache-bugjon-hall/promisify-node:feature/unwrapped-function-cache-bugCopy head branch name to clipboard
Merged
Fix issue with async functions being cached as-is, and so not getting…#14maxkorp merged 1 commit intonodegit:masternodegit/promisify-node:masterfrom jon-hall:feature/unwrapped-function-cache-bugjon-hall/promisify-node:feature/unwrapped-function-cache-bugCopy head branch name to clipboard
maxkorp merged 1 commit intonodegit:masternodegit/promisify-node:masterfrom
jon-hall:feature/unwrapped-function-cache-bugjon-hall/promisify-node:feature/unwrapped-function-cache-bugCopy head branch name to clipboard
Conversation
Contributor
|
Seems like the test errors on this were just network glitches on travis, starting those over again 👍 |
Contributor
|
Ah, so, it's a module install failure against node 0.8, so pending hearing back from other maintainers re: dropping 0.8 support (its a weeee bit out of date at this point), this should be good to merge 👍 |
Contributor
|
Can you rebase this on top of master please, to get the updated version matrix (it doesnt appear there were any other changes, so a rebase should be safe). |
… wrapped if they are encountered elsewhere in the object being promisified.
f7279a6 to
fe2b27c
Compare
Contributor
Author
|
Cheers for updating the test config so quickly 😃, rebased and pushed and it looks like everything passes now. |
Contributor
|
Shoop da woop! |
maxkorp
added a commit
that referenced
this pull request
Nov 30, 2015
…-bug Fix issue with async functions being cached as-is, and so not getting…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… wrapped if they are encountered elsewhere in the object being promisified.
Fixes #13.