Revert "Undo revert of refactored code"#11
Merged
johnhaley81 merged 1 commit intomasternodegit/promisify-node:masterfrom Aug 20, 2015
revert-7-fix-refactoringnodegit/promisify-node:revert-7-fix-refactoringCopy head branch name to clipboard
Merged
Revert "Undo revert of refactored code"#11johnhaley81 merged 1 commit intomasternodegit/promisify-node:masterfrom revert-7-fix-refactoringnodegit/promisify-node:revert-7-fix-refactoringCopy head branch name to clipboard
johnhaley81 merged 1 commit intomasternodegit/promisify-node:masterfrom
revert-7-fix-refactoringnodegit/promisify-node:revert-7-fix-refactoringCopy head branch name to clipboard
Conversation
Contributor
Author
|
That undo breaks more than just nodegit. We'll need better testing and probably figure out a better way to determine what methods to promisify. #7 (comment) |
johnhaley81
added a commit
that referenced
this pull request
Aug 20, 2015
Revert "Undo revert of refactored code"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7