Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Make Ignore.pathIsIgnored async #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnhaley81 merged 2 commits into from
Mar 28, 2016
Merged

Make Ignore.pathIsIgnored async #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ad0ef2
#Async4Lyfe
joshaber Mar 25, 2016
ffec49b
Update the test.
joshaber Mar 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion 4 generate/input/descriptor.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,9 +949,11 @@
"git_ignore_path_is_ignored": {
"args": {
"ignored": {
"shouldAlloc": true,
"isReturn": true
}
}
},
"isAsync": true
Copy link

@nathansobo nathansobo Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow it's pretty cool that this is all it took.

Copy link
Collaborator Author

@joshaber joshaber Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 👶

Copy link

@nathansobo nathansobo Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where'd this baby come from!? Now I gotta take care of it.

Copy link
Member

@tbranyen tbranyen Mar 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        🎉                                   🎉
    🎉 yeah, it's pretty cool        🎉
       🎉                 🎉
     🎉;     🎉
🐧

}
}
},
Expand Down
13 changes: 11 additions & 2 deletions 13 test/tests/ignore.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,16 @@ describe("Ignore", function() {
});

it("can determine if a path is ignored", function() {
assert.equal(Ignore.pathIsIgnored(this.repository, ".git"), true);
assert.equal(Ignore.pathIsIgnored(this.repository, "LICENSE"), false);
function expectIgnoreState(repo, fileName, expected) {
return Ignore.pathIsIgnored(repo, fileName)
.then(function(ignored) {
assert.equal(ignored, expected);
});
}

return Promise.all([
expectIgnoreState(this.repository, ".git", true),
expectIgnoreState(this.repository, "LICENSE", false)
]);
});
});
Morty Proxy This is a proxified and sanitized view of the page, visit original site.