Use type safe pointer instead of void * for New#957
Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom Mar 18, 2016
Merged
Use type safe pointer instead of void * for New#957johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
Conversation
| {% if field.hasConstructor |or field.isLibgitType %} | ||
| Local<Object> {{ field.name }}Temp = {{ field.cppClassName }}::New( | ||
| &this->raw->{{ field.name }}, | ||
| {%if not field.cType|isPointer %}&{%endif%}this->raw->{{ field.name }}, |
Collaborator
|
👍 to type safety. Thanks @srajko |
johnhaley81
added a commit
that referenced
this pull request
Mar 18, 2016
Use type safe pointer instead of void * for New
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this as part of #955.
Changing the
rawpointer fromvoid *toconst {{ cType }} *to add type safety. The change actually caught a problem instruct_content.ccwhere we were sometimes taking the address of a pointer and passing that in instead of the pointer (forgit_checkout_options.baseline, we were sending in agit_tree **instead of agit_tree *toNew).