Put the path to node-pre-gyp in quotes in install.js#951
Closed
ksambhi wants to merge 13 commits intonodegit:masternodegit/nodegit:masterfrom
ksambhi:fix-install-issue-username-space-windowsksambhi/nodegit:fix-install-issue-username-space-windowsCopy head branch name to clipboard
Closed
Put the path to node-pre-gyp in quotes in install.js#951ksambhi wants to merge 13 commits intonodegit:masternodegit/nodegit:masterfrom ksambhi:fix-install-issue-username-space-windowsksambhi/nodegit:fix-install-issue-username-space-windowsCopy head branch name to clipboard
ksambhi wants to merge 13 commits intonodegit:masternodegit/nodegit:masterfrom
ksambhi:fix-install-issue-username-space-windowsksambhi/nodegit:fix-install-issue-username-space-windowsCopy head branch name to clipboard
Conversation
This is to help resolve nodegit#950
Contributor
Author
|
The linting script appears to be failing (appveyor build) due to my usage of quotes: |
added 2 commits
March 15, 2016 12:28
This should fix building for node 5.8.0+
Collaborator
|
Do |
Contributor
Author
|
Ok |
When building on appveyor, the linter exited with 1. To fix this, we are putting an \ before "
Contributor
Author
|
Test status: |
Member
|
@Gum-Joe you are correct, my server is down which is causing the failure. |
Collaborator
|
@Gum-Joe can you rebase this on top of master please? |
Contributor
Author
|
:@johnhaley81 Rebasing now |
This should fix building for node 5.8.0+
…thub.com/Gum-Joe/nodegit into fix-install-issue-username-space-windows Get ready for a merge and rebase for pull request nodegit#951
This is to help resolve nodegit#950
When building on appveyor, the linter exited with 1. To fix this, we are putting an \ before "
…thub.com/Gum-Joe/nodegit into fix-install-issue-username-space-windows For pull request nodegit#951
Contributor
Author
|
Just rebased. Now pull requests will not merge |
Collaborator
Contributor
Author
|
How can I fix this? |
Contributor
Author
|
Oh... Now GitHub says it can merge. |
Member
|
It might be better to just merge locally @johnhaley |
johnhaley81
pushed a commit
that referenced
this pull request
Mar 16, 2016
…e-windows' Put the path to node-pre-gyp in quotes in install.js
Collaborator
Collaborator
|
Thanks @Gum-Joe! |
Contributor
Author
|
Your welcome @johnhaley81 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When I was installing nodegit, I found that there was compilation issues (#950). On further inspection, I found out that the building was taking place due to it failing to install a S3 binary. This was due to my user folder having a space in.
To fix this, I have placed the command in quotes.
Current Issues:
install.jsnow assumes that the install is a local install, even though that part of code was untouched.