Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Tests: generalized createConflict in index utils#936

Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
smith-kyle:test-index-utilssmith-kyle/nodegit:test-index-utilsCopy head branch name to clipboard
Mar 7, 2016
Merged

Tests: generalized createConflict in index utils#936
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
smith-kyle:test-index-utilssmith-kyle/nodegit:test-index-utilsCopy head branch name to clipboard

Conversation

@smith-kyle
Copy link
Contributor

The createConflict function in test/utils/index_setup.js was specialized for a specific index test. This PR generalizes it so it can be used in future tests.

Leave the repository in a conflicted state and return the index rather
than the IndexEntries of the ancestor, ours, and theirs
@smith-kyle
Copy link
Contributor Author

My bad this test is fixed now 👍

@tbranyen
Copy link
Member

tbranyen commented Mar 4, 2016

👍 Changes look good to me, @johnhaley81 I'll let you merge if it all looks right to you

@johnhaley81
Copy link
Collaborator

👍 thanks again @smith-kyle

johnhaley81 added a commit that referenced this pull request Mar 7, 2016
Tests: generalized createConflict in index utils
@johnhaley81 johnhaley81 merged commit 8ec7a58 into nodegit:master Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.