Add throttling support for callbacks#932
Merged
johnhaley81 merged 6 commits intonodegit:masternodegit/nodegit:masterfrom Mar 3, 2016
Merged
Add throttling support for callbacks#932johnhaley81 merged 6 commits intonodegit:masternodegit/nodegit:masterfrom
johnhaley81 merged 6 commits intonodegit:masternodegit/nodegit:masterfrom
Conversation
4301cfe to
be11a91
Compare
Collaborator
|
This will fix #919 |
be11a91 to
6aa0398
Compare
Collaborator
|
@srajko can you add a test to confirm that the callback is indeed being throttled? It could be another clone test. |
8b961c7 to
8672782
Compare
Collaborator
Author
|
The changes are as follows:
See commit descriptions for a rundown. |
8672782 to
963d0f2
Compare
just refactoring, eliminating duplicated code
I originally tried doing the throttling in the baton but that ended up being a mistake. This moved the default result to the baton so the baton could use it. I don't think the change is necessary for the final version of this PR, but I still like moving things out of combyne-templated files so I kept it.
just refactoring, leverages the previously unused CallbackWrapper to set us up for bundling throttling state with the javascript callback.
default settings for progress callbacks.
963d0f2 to
b6215ac
Compare
Collaborator
|
👍 nice job! Thanks @srajko |
| bool done; | ||
| }; | ||
|
|
||
| template<typename ResultT> |
johnhaley81
added a commit
that referenced
this pull request
Mar 3, 2016
Add throttling support for callbacks
johnhaley81
added a commit
that referenced
this pull request
Mar 7, 2016
A non-trivial number of segfaults are seeing this in production. Pulling this back for right now until a later release where we can fix them.
johnhaley81
added a commit
that referenced
this pull request
Mar 7, 2016
Revert "Merge pull request #932 from srajko/callback-throttle"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.