Let my patches go#930
Merged
johnhaley81 merged 2 commits intomasternodegit/nodegit:masterfrom Feb 29, 2016
Merged
Conversation
Collaborator
Author
|
(Also cc atom/atom#10931.) |
Collaborator
|
Yeah, I swore I commented on that exact line saying "These need to be freed" but I can't find it now. /shrug |
Member
|
Oh wow, good catch. Thanks! |
Member
|
That should take care of the problem, the intention of this C++ rewrite was to do exactly that, free the patches after we use them. I definitely accidentally a line. |
Collaborator
Author
|
Verified this fixes the issue we were seeing in Atom 👍 |
6 tasks
Collaborator
|
👍 Thanks @joshaber |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #877.
It looks like #883 was supposed to fix this, but we missed the part where we actually did the free’ing. 🙈
This is only WIP because I’m still trying to make a build so I can test that this fixes the whole problem.