Fix compilation for systems != windows and crash in diff function#922
Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom Feb 25, 2016
viatsko:fix-libgit2-crashCopy head branch name to clipboard
Merged
Fix compilation for systems != windows and crash in diff function#922johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom viatsko:fix-libgit2-crashCopy head branch name to clipboard
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
viatsko:fix-libgit2-crashCopy head branch name to clipboard
Conversation
Collaborator
|
Yup, this one's a doozy. |
Collaborator
Collaborator
|
@johnhaley81 Verified builds on 0.36.8. 👍 |
Collaborator
johnhaley81
added a commit
that referenced
this pull request
Feb 25, 2016
Fix compilation for systems != windows and crash in diff function
|
❤️ ✨ |
|
❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Atom crashed because of atom/atom#10965
Here's the same fix we've used for git-utils atom/git-utils#61
Full story about this bug in libgit2 issues tracker here libgit2/libgit2#2586
Please review as this makes library unusable in a lot of use-cases. :(