Fix callback out values in callbacks from C++#921
Merged
johnhaley81 merged 1 commit intomasternodegit/nodegit:masterfrom Feb 24, 2016
fix-random-memory-issues-in-callbacksnodegit/nodegit:fix-random-memory-issues-in-callbacksCopy head branch name to clipboard
Merged
Fix callback out values in callbacks from C++#921johnhaley81 merged 1 commit intomasternodegit/nodegit:masterfrom fix-random-memory-issues-in-callbacksnodegit/nodegit:fix-random-memory-issues-in-callbacksCopy head branch name to clipboard
johnhaley81 merged 1 commit intomasternodegit/nodegit:masterfrom
fix-random-memory-issues-in-callbacksnodegit/nodegit:fix-random-memory-issues-in-callbacksCopy head branch name to clipboard
Conversation
We were passing back the memory address that was actually controlled by V8 to all C/C++ callbacks which could get randomly moved by V8 at random times causing random segfaults randomly. http://i.imgur.com/rB4Hux7.gif
johnhaley81
added a commit
that referenced
this pull request
Feb 24, 2016
…backs Fix callback out values in callbacks from C++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were passing back the memory address that was actually controlled by V8 to all C/C++ callbacks which could get randomly moved by V8 at random times causing random segfaults randomly.
http://i.imgur.com/rB4Hux7.gif