Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix stageLines#906

Merged
johnhaley81 merged 2 commits intomasternodegit/nodegit:masterfrom
fix-stage-linesnodegit/nodegit:fix-stage-linesCopy head branch name to clipboard
Feb 16, 2016
Merged

Fix stageLines#906
johnhaley81 merged 2 commits intomasternodegit/nodegit:masterfrom
fix-stage-linesnodegit/nodegit:fix-stage-linesCopy head branch name to clipboard

Conversation

@joshaber
Copy link
Collaborator

There were a couple funny things:

  1. Removing the index lock seems out of place for this function.
  2. We should calculate the diff after refreshing the index.


var indexLock = repo.path().replace(".git/", "") + ".git/index.lock";

return fse.remove(indexLock)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnhaley81
Copy link
Collaborator

LGTM. Gracias amigo.

johnhaley81 added a commit that referenced this pull request Feb 16, 2016
@johnhaley81 johnhaley81 merged commit 895d5e6 into master Feb 16, 2016
@johnhaley81 johnhaley81 deleted the fix-stage-lines branch February 16, 2016 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.