Made the tests pass and making each test self-contained#90
Merged
nkallen merged 1 commit intonodegit:masternodegit/nodegit:masterfrom Sep 8, 2013
FrozenCow:selfcontained_testsFrozenCow/nodegit:selfcontained_testsCopy head branch name to clipboard
Merged
Made the tests pass and making each test self-contained#90nkallen merged 1 commit intonodegit:masternodegit/nodegit:masterfrom FrozenCow:selfcontained_testsFrozenCow/nodegit:selfcontained_testsCopy head branch name to clipboard
nkallen merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
FrozenCow:selfcontained_testsFrozenCow/nodegit:selfcontained_testsCopy head branch name to clipboard
Conversation
nkallen
added a commit
that referenced
this pull request
Sep 8, 2013
Made the tests pass and making each test self-contained
Contributor
|
These improvements are enough to make @FrozenCow a committer IMO. I've added him as an owner. @FrozenCow fixes like this -- compile errors / warnings / broken tests / etc. Go ahead and just commit to master. For more substantive changes continue to use pull requests? |
Member
|
Sounds good to me. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed tree.js not passing: changed '1e7bc7fba93aabc8c76ebea41918f9ad892141ed' to sha.
Added setUp and tearDown steps so that each step is starting with a clean slate and note (purposely) relying on previous steps.
Travis should be working again with this patch (fingers crossed).