Fixed compile error: memcpy not defined#89
Merged
nkallen merged 3 commits intonodegit:masternodegit/nodegit:masterfrom Sep 8, 2013
Merged
Fixed compile error: memcpy not defined#89nkallen merged 3 commits intonodegit:masternodegit/nodegit:masterfrom
nkallen merged 3 commits intonodegit:masternodegit/nodegit:masterfrom
Conversation
Specifically the return values of git_index_find and git_odb_read_header.
Closed
nkallen
added a commit
that referenced
this pull request
Sep 8, 2013
Fixed compile error: memcpy not defined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could not compile on ArchLinux (with gcc 4.8.1) and Ubuntu. 9365962 change should fix that.
Additionally fixed a few of the compiler warnings that showed up. I'm not entirely sure you like how I fixed those, but give v0.18.0.json and the .ejs files a look.
Also, I think 6ca5347 is not only a fix for the warning, but it seemed actually an error (that would happen at runtime). The functions are unused at the moment, so for now I just focused on fixing the warning.
There are still 2 compiler warnings left:
I introduced this one, but I couldn't figure out a nice way to fix this with the templates. However a unused variable is less severe than a type-cast warning.
Next there is still this warning, which also has to do with a parameter that should be marked as "isReturn". When I did that other things broke and couldn't figure out how to fix this properly.
I have to say that I like how simple most of the templating is btw. It's good to see a bunch of warnings being resolved by one change in the templates too.