Clean mutexes as part of garbage collection cycle instead of uv_async#880
Merged
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom Jan 28, 2016
Merged
Clean mutexes as part of garbage collection cycle instead of uv_async#880johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
johnhaley81 merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
Conversation
Member
|
😍 |
johnhaley81
added a commit
that referenced
this pull request
Jan 28, 2016
Clean mutexes as part of garbage collection cycle instead of uv_async
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leaving the
uv_asynchandle open was causing the node process to hang on exit. Cleaning up mutexes on garbage collection achieves the same goal (mutexes will get cleaned up at some point, when they are no longer needed), and avoids the issue.Using the GC is probably better performance-wise with thread safety enabled (mutex cleanup should be less frequent). With thread-safety disabled, the mutex cleanup gets skipped (though for simplicity, the GC callback is configured throughout - I imagine this has minimal performance impact).
Fixes #866.