Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add missing 'promise' dependency#878

Closed
lowellk wants to merge 1 commit intonodegit:masternodegit/nodegit:masterfrom
lowellk:masterlowellk/nodegit:masterCopy head branch name to clipboard
Closed

Add missing 'promise' dependency#878
lowellk wants to merge 1 commit intonodegit:masternodegit/nodegit:masterfrom
lowellk:masterlowellk/nodegit:masterCopy head branch name to clipboard

Conversation

@lowellk
Copy link

@lowellk lowellk commented Jan 22, 2016

No description provided.

@johnhaley81
Copy link
Collaborator

All of the versions of node that we target have Promise natively. Where is this breaking for you?

@lowellk
Copy link
Author

lowellk commented Jan 22, 2016

@johnhaley81 I'm running node 0.10. Is that not supported?

@johnhaley81
Copy link
Collaborator

Unfortunately no. We decided to stop support for node v0.10 when 5 was released. Are you able to use NodeGit in v0.10 with this patch?

@lowellk
Copy link
Author

lowellk commented Jan 26, 2016

My system was running 0.10 but I realize the best solution for me is to simply upgrade my version. Thanks for responding.

@lowellk lowellk closed this Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.