Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix manual install#835

Merged
maxkorp merged 4 commits intomasternodegit/nodegit:masterfrom
fix-manual-installnodegit/nodegit:fix-manual-installCopy head branch name to clipboard
Dec 16, 2015
Merged

Fix manual install#835
maxkorp merged 4 commits intomasternodegit/nodegit:masterfrom
fix-manual-installnodegit/nodegit:fix-manual-installCopy head branch name to clipboard

Conversation

@maxkorp
Copy link
Collaborator

@maxkorp maxkorp commented Dec 16, 2015

Fixes an issue where when manuallybuilding after a failed download, "undefined" would sneak in to the arguments for node-gyp. Also updates missing changelog entries (not including 0.5.x) and bumps to 0.6.3

@maxkorp
Copy link
Collaborator Author

maxkorp commented Dec 16, 2015

This passed on appveyor the previous commit, and i only changed the travisyml, and travis has passed so I'm merging this. @johnhaley81 reviewed this just to be safe.

maxkorp added a commit that referenced this pull request Dec 16, 2015
@maxkorp maxkorp merged commit d120199 into master Dec 16, 2015
@maxkorp maxkorp deleted the fix-manual-install branch December 16, 2015 17:57
@johnhaley81
Copy link
Collaborator

@maxkorp you missed v0.5.0 in the CHANGELOG.md fyi

@maxkorp
Copy link
Collaborator Author

maxkorp commented Dec 17, 2015

@johnhaley81 you missed my note about that :D

my note about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.