Merged
Conversation
…s is fully code-gen'd and all tests pass.
Member
|
Yup failing because of the issue I mentioned before: "AssertionError: 'The Should be an easy fix. I can look into it tomorrow. |
Member
|
@nkallen that fix will still fail since Maybe this? b/test/repo.js
index fa6bcd3..886dee0 100644
--- a/test/repo.js
+++ b/test/repo.js
@@ -11,8 +11,8 @@ exports.open = function(test){
test.expect(2);
// Test invalid repository
- git.Repo.open('/private/etc/hosts', function(error, repository) {
- test.equals(error.message, "The `.git` file at '/private/etc/hosts' is malformed");
+ git.Repo.open('../templates', function(error, repository) {
+ test.equals(error.message, "Could not find repository from '../templates'");
// Test valid repository
git.Repo.open('../.git', function(error, repository) { |
Contributor
Author
|
Do you guys have any comments? Should I just merge this into the WIP? |
Member
|
Hey @nkallen looks good to me. 👍 |
Member
|
I've forked a branch from your's in anticipation and started rewriting our installer to be cross platform with Windows. |
tbranyen
added a commit
that referenced
this pull request
Aug 5, 2013
Collaborator
|
This is great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codgen C++ Glue