This fixes polling sync promises in callbacks.#546
Merged
tbranyen merged 2 commits intomasternodegit/nodegit:masterfrom Apr 20, 2015
fix-promises-in-callbacksnodegit/nodegit:fix-promises-in-callbacksCopy head branch name to clipboard
Merged
This fixes polling sync promises in callbacks.#546tbranyen merged 2 commits intomasternodegit/nodegit:masterfrom fix-promises-in-callbacksnodegit/nodegit:fix-promises-in-callbacksCopy head branch name to clipboard
tbranyen merged 2 commits intomasternodegit/nodegit:masterfrom
fix-promises-in-callbacksnodegit/nodegit:fix-promises-in-callbacksCopy head branch name to clipboard
Conversation
This also fixes #497.
Collaborator
Author
|
@tbranyen looks like the coverage testing stuff for C++ is breaking? Weird. I'm going to redo that test. |
12ac422 to
96b39b0
Compare
tbranyen
added a commit
that referenced
this pull request
Apr 20, 2015
This fixes polling sync promises in callbacks.
Member
|
Awwww yeah! I pushed a new commit, fixed the weird issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes #497.