Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add convenience methods to status file#524

Merged
tbranyen merged 2 commits intomasternodegit/nodegit:masterfrom
status-file-extrasnodegit/nodegit:status-file-extrasCopy head branch name to clipboard
Apr 18, 2015
Merged

Add convenience methods to status file#524
tbranyen merged 2 commits intomasternodegit/nodegit:masterfrom
status-file-extrasnodegit/nodegit:status-file-extrasCopy head branch name to clipboard

Conversation

@maxkorp
Copy link
Collaborator

@maxkorp maxkorp commented Apr 2, 2015

Adds methods inWorkingTree and inIndex to StatusFiles. These just check it the status contains any WT_xxx status codes (or INDEX_xxx). It's very possible that a status could have both (eg if you've done a patch stage).

@maxkorp
Copy link
Collaborator Author

maxkorp commented Apr 2, 2015

My only thought is that I'm not super hot on the method names. Anybody have any better ideas?

@johnhaley81
Copy link
Collaborator

I think the names are ok. Maybe isInWorkingTree? But that's sounding to verbose to me.

@tbranyen
Copy link
Member

The names make sense to me. Merging, thanks!

tbranyen added a commit that referenced this pull request Apr 18, 2015
Add convenience methods to status file
@tbranyen tbranyen merged commit 2b009fd into master Apr 18, 2015
@tbranyen tbranyen deleted the status-file-extras branch April 18, 2015 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.