Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update Checkout and Merge#505

Merged
tbranyen merged 4 commits intomasternodegit/nodegit:masterfrom
ol-checkout-and-merge-indexnodegit/nodegit:ol-checkout-and-merge-indexCopy head branch name to clipboard
Mar 22, 2015
Merged

Update Checkout and Merge#505
tbranyen merged 4 commits intomasternodegit/nodegit:masterfrom
ol-checkout-and-merge-indexnodegit/nodegit:ol-checkout-and-merge-indexCopy head branch name to clipboard

Conversation

@orderedlist
Copy link
Collaborator

Checkout.head manipulates the index, where in these scenarios we only want to update the working tree. Tests now verify the index isn't changed when merging and checking out.

@orderedlist
Copy link
Collaborator Author

Wat? Not sure why the first 5 commits are showing here. Pretty positive I branched from master...

@johnhaley81
Copy link
Collaborator

That's weird. Rebase on master?

Checkout.head futzes with the index, and that's not what we want in a branch
checkout
Don't need to manipulate the index in this scenario
@orderedlist orderedlist force-pushed the ol-checkout-and-merge-index branch from 1880360 to 7775aa7 Compare March 22, 2015 17:39
@tbranyen
Copy link
Member

Awesome, thanks @orderedlist!

tbranyen added a commit that referenced this pull request Mar 22, 2015
@tbranyen tbranyen merged commit 1cfacc7 into master Mar 22, 2015
@tbranyen tbranyen deleted the ol-checkout-and-merge-index branch March 22, 2015 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.