Fix trailing space in atom-shell windows install#480
Merged
johnhaley81 merged 1 commit intomasternodegit/nodegit:masterfrom Mar 10, 2015
Merged
Fix trailing space in atom-shell windows install#480johnhaley81 merged 1 commit intomasternodegit/nodegit:masterfrom
johnhaley81 merged 1 commit intomasternodegit/nodegit:masterfrom
Conversation
When installing on atom-shell in windows it would add a trailing space to the .atom-shell-gyp directory. Removing that directory is a pain since windows doesn't handle trailing spaces too well. This is an attempt to fix that.
johnhaley81
added a commit
that referenced
this pull request
Mar 10, 2015
Fix trailing space in atom-shell windows install
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing on atom-shell in windows it would add a trailing
space to the .atom-shell-gyp directory. Removing that directory is
a pain since windows doesn't handle trailing spaces too well.
This is an attempt to fix that.