Test in Node 0.12 and io.js#468
Merged
johnhaley81 merged 9 commits intomasternodegit/nodegit:masterfrom Mar 11, 2015
Merged
Conversation
Collaborator
|
👍 |
Collaborator
|
https://travis-ci.org/nodegit/nodegit/jobs/53249611#L528 I'm going to cancel and restart this in Travis |
Collaborator
|
Interesting... it didn't queue up on Travis. |
Collaborator
|
Right? o.O |
Collaborator
|
W/e, just reset to the prior commit and recommitted the same changes. |
Collaborator
|
I'm switching us over to use https://github.com/rvagg/pangyp until nodejs/node-gyp#564 is merged. Reference: nodejs/node#433 |
added 2 commits
March 10, 2015 15:38
Currently there's a PR (nodejs/node-gyp#564) that's awaiting a merge that will allow us to once again use node-gyp to compile nodegit across all platforms. Until that is merged however we can use pangyp as a stop-gap. After that PR is merged though we should switch back to node-gyp.
ea11429 to
c59309c
Compare
Collaborator
|
We might want to bump up timeouts on our CI tests since Travis has been running slow lately. |
Collaborator
|
Pretty sure this was the issue. |
Collaborator
|
Getting |
Collaborator
|
pangyp currently doesn't work in windows for iojs :( |
Collaborator
|
Should we just keep going on with the caveat of "Does not work in iojs for windows right now"? |
Member
Author
|
Yup, works well for me! |
johnhaley81
added a commit
that referenced
this pull request
Mar 11, 2015
Test in Node 0.12 and io.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.