Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix push example#462

Merged
johnhaley81 merged 1 commit intomasternodegit/nodegit:masterfrom
fix-push-examplenodegit/nodegit:fix-push-exampleCopy head branch name to clipboard
Mar 5, 2015
Merged

Fix push example#462
johnhaley81 merged 1 commit intomasternodegit/nodegit:masterfrom
fix-push-examplenodegit/nodegit:fix-push-exampleCopy head branch name to clipboard

Conversation

@johnhaley81
Copy link
Collaborator

No description provided.

@johnhaley81
Copy link
Collaborator Author

Hmm, this shouldn't have died on Appveyor.

@johnhaley81
Copy link
Collaborator Author

It's a little worrisome that 1312 died but 1313 didn't.

It seems like we might be missing something cleaning up on windows again @tbranyen @mattyclarkson.

@mattyclarkson
Copy link
Collaborator

Well done for clearing up the example. I was looking through the generated code and it looks like it could do with an audit. I tried putting valgrind and electricfence around them but it looks like the way node runs stuff they still didn't pick things up. I can look into putting -fsantize=address onto the debug builds so that we get a stack trace if anything references out of scope of the allocated memory. The other thing that would be useful is -fsanitize=thread as that will catch any threading errors due to the way the generated code is using libuv?

Unfortunately the thread and address sanitizers cannot be compiled in together so we'd have to have two build variants. I'd have to look into if that is even supported with node generate and gyp. It'd be great to have a Release, Debug, Address and Thread that instruments the code in certain ways.

@johnhaley81
Copy link
Collaborator Author

That's a good idea. I think that would be great for post 0.3.0 release. I'm going to merge this in since it's unrelated.

johnhaley81 added a commit that referenced this pull request Mar 5, 2015
@johnhaley81 johnhaley81 merged commit 25feff1 into master Mar 5, 2015
@johnhaley81 johnhaley81 deleted the fix-push-example branch March 5, 2015 20:00
@johnhaley81 johnhaley81 added this to the 0.3.0 milestone Mar 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.