Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Include missing lib files in nodegit.js template#455

Merged
tbranyen merged 2 commits intomasternodegit/nodegit:masterfrom
ol-fix-including-libnodegit/nodegit:ol-fix-including-libCopy head branch name to clipboard
Mar 3, 2015
Merged

Include missing lib files in nodegit.js template#455
tbranyen merged 2 commits intomasternodegit/nodegit:masterfrom
ol-fix-including-libnodegit/nodegit:ol-fix-including-libCopy head branch name to clipboard

Conversation

@orderedlist
Copy link
Collaborator

We should probably script these inclusions, so future additions don't get
missed.

We should probably script these inclusions, so future additions don't get 
missed.
@orderedlist
Copy link
Collaborator Author

There were a few classes here (Reset for example) that worked in the tests because we were directly requiring the lib file, but not when using NodeGit.Reset.

@johnhaley81
Copy link
Collaborator

Eventually we'll need to do #456

@johnhaley81 johnhaley81 modified the milestone: 0.3.0 Mar 3, 2015
@tbranyen
Copy link
Member

tbranyen commented Mar 3, 2015

This now resolves #456 as well.

@tbranyen tbranyen force-pushed the ol-fix-including-lib branch from b80a4b8 to 4134442 Compare March 3, 2015 17:10
tbranyen added a commit that referenced this pull request Mar 3, 2015
Include missing lib files in nodegit.js template
@tbranyen tbranyen merged commit 2542c04 into master Mar 3, 2015
@tbranyen tbranyen deleted the ol-fix-including-lib branch March 3, 2015 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.