StrArray memory fix#454
Merged
mattyclarkson merged 3 commits intonodegit:masternodegit/nodegit:masterfrom Mar 3, 2015
mattyclarkson:str-array-memory-fixmattyclarkson/nodegit:str-array-memory-fixCopy head branch name to clipboard
Merged
StrArray memory fix#454mattyclarkson merged 3 commits intonodegit:masternodegit/nodegit:masterfrom mattyclarkson:str-array-memory-fixmattyclarkson/nodegit:str-array-memory-fixCopy head branch name to clipboard
mattyclarkson merged 3 commits intonodegit:masternodegit/nodegit:masterfrom
mattyclarkson:str-array-memory-fixmattyclarkson/nodegit:str-array-memory-fixCopy head branch name to clipboard
Conversation
Collaborator
Author
|
@johnhaley81, could you just put your eyes over this before I merge? |
Collaborator
|
This is a much better way to allocate memory for the structure. I added a minor comment but after that 👍 |
7c81612 to
3e5cb89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were only allocating enough memory for a
git_strarraymemory pointer rather than the structure. 1a74a2d fixes that.7c81612 changes the code to allocate the memory for the structure and the string pointers all in one go to reduce fragmentation. Complete micro-optimisation, happy for it to not get merged but thought I'd do it anyway.