Fix libuv threading issue#435
Merged
johnhaley81 merged 2 commits intomasternodegit/nodegit:masterfrom Feb 27, 2015
Merged
Conversation
|
Note that |
Collaborator
Author
|
Ahhh interesting. That probably should be a note for that method. I'll fix that in this PR. Thanks for the heads up @saghul! |
Collaborator
Author
Collaborator
Author
|
@tjfontaine was saying that we should be doing something like this. I think I'm going to merge this for right now and tackle that later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv_queue_workis not thread safeThis means that all callbacks are in a highly unstable
state and can bring the system down at any time.
Now we're using an Async handle
That should make out callbacks thread safe and consistent
across platforms again