Skip transfer progress test until it's fixed#433
Merged
tbranyen merged 1 commit intomasternodegit/nodegit:masterfrom Feb 27, 2015
skip-transfer-progress-testnodegit/nodegit:skip-transfer-progress-testCopy head branch name to clipboard
Merged
Skip transfer progress test until it's fixed#433tbranyen merged 1 commit intomasternodegit/nodegit:masterfrom skip-transfer-progress-testnodegit/nodegit:skip-transfer-progress-testCopy head branch name to clipboard
tbranyen merged 1 commit intomasternodegit/nodegit:masterfrom
skip-transfer-progress-testnodegit/nodegit:skip-transfer-progress-testCopy head branch name to clipboard
Conversation
Currently the transfer progress test is breaking on windows randomly. @tbranyen and I have been looking into it and it seems like a libuv issue. I'm going to skip this now so that other potential PR's aren't held up by it until we can get a good resolution and fix it in another PR
Member
|
👍 No point in getting held up by a random Windows segfault not related to our code. |
tbranyen
added a commit
that referenced
this pull request
Feb 27, 2015
Skip transfer progress test until it's fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the transfer progress test is breaking on windows
randomly. @tbranyen and I have been looking into it and it seems
like a libuv issue. I'm going to skip this now so that other
potential PR's aren't held up by it until we can get a good
resolution and fix it in another PR