Fix callbacks with just return value and single payload#416
Merged
johnhaley81 merged 11 commits intomasternodegit/nodegit:masterfrom Feb 24, 2015
Merged
Fix callbacks with just return value and single payload#416johnhaley81 merged 11 commits intomasternodegit/nodegit:masterfrom
johnhaley81 merged 11 commits intomasternodegit/nodegit:masterfrom
Conversation
95e1c5d to
413d7e9
Compare
413d7e9 to
ab1595d
Compare
e0e6bfa to
6de7e3b
Compare
added 11 commits
February 24, 2015 12:35
If a function has a callback then it must be async. If it isn't then we'll hit a deadlocked state when waiting for the JS callback.
[ci skip]
6de7e3b to
dece787
Compare
johnhaley81
added a commit
that referenced
this pull request
Feb 24, 2015
Fix callbacks with just return value and single payload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix #395