Tree Entry getBlob() should also support the callback pattern.#405
Merged
tbranyen merged 1 commit intonodegit:masternodegit/nodegit:masterfrom Feb 14, 2015
jeffwilcox:tree_entry_getBlob_callbackCopy head branch name to clipboard
Merged
Tree Entry getBlob() should also support the callback pattern.#405tbranyen merged 1 commit intonodegit:masternodegit/nodegit:masterfrom jeffwilcox:tree_entry_getBlob_callbackCopy head branch name to clipboard
tbranyen merged 1 commit intonodegit:masternodegit/nodegit:masterfrom
jeffwilcox:tree_entry_getBlob_callbackCopy head branch name to clipboard
Conversation
Contributor
Author
|
FYI, this is the rebased version of #404. Not sure why I closed the other PR to do this. I need ☕ . |
Member
|
Looks good, thanks! |
tbranyen
added a commit
that referenced
this pull request
Feb 14, 2015
Tree Entry getBlob() should also support the callback pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While moving code from the older v0.1.x codebase to the latest, I tried making minimal changes and renames in some functions. A majority of my Node code at this time is not using promises. While calling
getBlob(callback)on a tree_entry, nothing happened.I simply mimicked the format used for
getTreein tree_entry to be consistent (although I'm not setting theentryinstance on a property like the tree function does).