Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

WIP: Refactor publishing#350

Closed
maxkorp wants to merge 16 commits intomasternodegit/nodegit:masterfrom
refactor-publishingnodegit/nodegit:refactor-publishingCopy head branch name to clipboard
Closed

WIP: Refactor publishing#350
maxkorp wants to merge 16 commits intomasternodegit/nodegit:masterfrom
refactor-publishingnodegit/nodegit:refactor-publishingCopy head branch name to clipboard

Conversation

@maxkorp
Copy link
Collaborator

@maxkorp maxkorp commented Jan 14, 2015

So I've done quite a bit here.

  • First of all, we've minimized the dependency list for normal non dev installs.
  • If the install happens from the NPM registry, we clean up after ourselves (cuts size by ~50%) including some extra dependencies (takes us well over 50% savings).
  • Added the option to do a debug build using BUILD_DEBUG=1, and a shorthand npm run buildDebug
  • Moved node-webkit detection to an outside module
  • made it so generate scripts can be called on the command line, but require returns a function, rather than taking immediate effect.
  • moved all scripts out of the root directory and in to lifecyclescripts
  • prepublish step also downloads vendor deps, since those are now published.

@maxkorp maxkorp changed the title Refactor publishing WIP: Refactor publishing Jan 14, 2015
@maxkorp maxkorp force-pushed the refactor-publishing branch from e6c5819 to 7258070 Compare January 14, 2015 19:01
@maxkorp
Copy link
Collaborator Author

maxkorp commented Jan 14, 2015

So I'm trying to figure out why this fails on linux 10, something with content type headers not being set...
Definitely pretty confused.

@mcollina
Copy link
Collaborator

mcollina commented Jan 14, 2015

👍, but bump the minor version number when you release it. If it introduces the smallest bug, it will trouble people that depends on ~0.2.4. I suggest keeping this new 0.3 release in a new branch, just to simplify life for newcomers to the project, and merge when it is all done.

@maxkorp
Copy link
Collaborator Author

maxkorp commented Jan 14, 2015

I'm fine pushing it to an 0.3.0. Might be time for that bump soon anyways with the libgit changes from upstream.

@maxkorp maxkorp force-pushed the refactor-publishing branch 5 times, most recently from 2dfad62 to 6188842 Compare January 16, 2015 18:20
@maxkorp
Copy link
Collaborator Author

maxkorp commented Jan 16, 2015

During the refactor a version check got missed, which usually caused a different version of http_parser to get pulled in for v10. That wasnt happening, causing a mismatch.

@maxkorp maxkorp force-pushed the refactor-publishing branch 3 times, most recently from cc3e106 to d4bbb04 Compare January 19, 2015 19:34
@maxkorp maxkorp force-pushed the refactor-publishing branch from d4bbb04 to cad078e Compare January 19, 2015 19:52
@maxkorp
Copy link
Collaborator Author

maxkorp commented Jan 19, 2015

Making a new PR for the 0.3 branch.

@maxkorp maxkorp closed this Jan 19, 2015
@snyk-bot snyk-bot mentioned this pull request Jul 17, 2020
Open
@jmatsushita jmatsushita mentioned this pull request Jun 29, 2022
Open
@takeratta takeratta mentioned this pull request Nov 28, 2023
Open
@jmatsushita jmatsushita mentioned this pull request Dec 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxkorp @mcollina
Morty Proxy This is a proxified and sanitized view of the page, visit original site.