Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Added debug build instructions.#349

Merged
maxkorp merged 1 commit intomasternodegit/nodegit:masterfrom
debug-build-instructionsnodegit/nodegit:debug-build-instructionsCopy head branch name to clipboard
Jan 14, 2015
Merged

Added debug build instructions.#349
maxkorp merged 1 commit intomasternodegit/nodegit:masterfrom
debug-build-instructionsnodegit/nodegit:debug-build-instructionsCopy head branch name to clipboard

Conversation

@mcollina
Copy link
Collaborator

As discussed in #331.

@tbranyen
Copy link
Member

Thanks!

@johnhaley81
Copy link
Collaborator

Gracias amigo! :D

@maxkorp
Copy link
Collaborator

maxkorp commented Jan 13, 2015

One concern from my corner: I'm hoping to push a pretty large restructure of the build process this afternoon, which will invalidate these particular instructions (down to a simple "npm run build-debug" or such).

@maxkorp
Copy link
Collaborator

maxkorp commented Jan 14, 2015

Eh, that requires some bigger discussion before it can land. I'm merging this, no way did your readme change cause appveyor to fail.

maxkorp added a commit that referenced this pull request Jan 14, 2015
@maxkorp maxkorp merged commit ad51862 into master Jan 14, 2015
@tbranyen tbranyen deleted the debug-build-instructions branch January 14, 2015 01:52
@mcollina
Copy link
Collaborator Author

appveyor fails almost every time :(, what's is purpose once we get travis?

@johnhaley81
Copy link
Collaborator

It's the only real CI we have for windows. I can't figure out why it dies
though.

On Wed, Jan 14, 2015, 2:33 AM Matteo Collina notifications@github.com
wrote:

appveyor fails almost every time :(, what's is purpose once we get travis?


Reply to this email directly or view it on GitHub
#349 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.